-
Notifications
You must be signed in to change notification settings - Fork 434
Open mergeback PR last #3287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open mergeback PR last #3287
Conversation
This reduces the likelihood of publishing a tag but not a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reorders workflow steps to create the mergeback PR after the GitHub release is created, reducing the likelihood of publishing a tag but not a release.
- The "Create mergeback branch and PR" step is moved from before the release creation to after it
- The step execution order now ensures the release is fully published before initiating the mergeback process
| --notes-file "$PARTIAL_CHANGELOG" | ||
| - name: Create mergeback branch and PR | ||
| if: ${{ endsWith(github.ref_name, steps.getVersion.outputs.latest_release_branch) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also changed this so that we will try to open the mergeback even if the tag exists. This means we can retry generating the mergeback if this workflow fails, even if the tag is already published.
This reduces the likelihood of publishing a tag but not a release.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Dev only
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist